Fixes after Mark's 2024-02-28 review #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Three of the points from my review are not addressed by this commit (the ones about sections 9, 9.1 and 10.1) - is that deliberate? Also, given that you've taken up my suggestion to require ADQL 2.1 for RegTAP 1.2, this change should be added to the change log in Appendix D. |
|
On Mon, Mar 18, 2024 at 08:07:07AM -0700, Mark Taylor wrote:
Three of the points from my review are not addressed by this commit
(the ones about sections 9, 9.1 and 10.1) - is that deliberate?
No. Ahem. I think I have not saved before a make generate and then
just blindly loaded the changed file. Thanks a lot for double
checking.
Also, given that you've taken up my suggestion to require ADQL 2.1
for RegTAP 1.2, this change should be added to the change log in
Appendix D.
Jup. Went in in 8b720b6.
Better now?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://wiki.ivoa.net/twiki/bin/view/IVOA/RegTAP12RFC#Comments%20by%20_MarkTaylor