-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples still contain spurious xmlns declaration #2
Comments
I've created a draft erratum at https://wiki.ivoa.net/twiki/bin/view/IVOA/SSA-1_1-Err-3 |
On Sun, Dec 03, 2023 at 10:00:55PM -0800, James Dempsey wrote:
I've created a draft erratum at https://wiki.ivoa.net/twiki/bin/view/IVOA/SSA-1_1-Err-3
Would you also announce it to TCG and DAL?
Meanwhile, what I'd comment there would be: Can we perhaps use the
opportunity to update the namespace declaration to something correct
and modern, too? I'm pretty sure the way this is written will yield
bad element names unless xsi:noNamespaceSchemaLocation does more
magic than I think it does (I've not researched it). If these
VOTables work, they work because of client lenience.
I'd say we should fix this to the plain:
<VOTable xmlns="http://www.ivoa.net/xml/VOTable/v1.1" version="1.1">
or even better (for my taste)
<VOTable xmlns="http://www.ivoa.net/xml/VOTable/v1.3" version="1.4">
(1.4 should be backward compatible, so if something was valid for
1.1, it should be valid for 1.4, too). *If* we want to give the
namespace location -- and I don't think that's necessarily a good
idea: people should use stilts votlint to validate VOTables, not some
generic XSD validator --, we could add something like
xsi:schemaLocation="http://www.ivoa.net/xml/VOTable/v1.3 http://www.ivoa.net/xml/VOTable/v1.3"
…-- and then we'd need to retain the xsi namespace declaration; but
again, I think that would be useless distraction.
|
While I somewhat fear opening a can of worms by seeking to correct other things that are wrong in these examples (there are several including missing angle brackets, bad OPTION content, incorrect capitalization of RESOURCE type attribute values, ...) it would seem perverse to replace a line of VOTable with another line that is both incorrect and gratuitously confusing. So I support Markus's suggestion to replace all the VOTABLE start tags in the examples with
which is the minimal correct formulation for VOTable 1.1. I suggest that we don't update it to version 1.4, on the grounds that this is really a correction not an update, and I don't think we should give the impression that we're doing anything other than fixing (some) broken stuff. The erratum text could include something like the additional sentence
(though you might be able to word that better) |
Thanks for those suggestions - I've updated the new VOTABLE start tags and mentioned it in the rationale. |
I removed some rogue " |
Ah, I spotted the ones at the front, but not the back, of each example - must have come from the copy somehow! Thanks for the fix. |
SSAP used to require that people include a spurious XML prefix mapping for ssa
(the idea was to use that to somehow introduce some sort of versioning).
This was fortunately dropped in 1.1, but the examples in the appendix
still have
Let's drop those.
The text was updated successfully, but these errors were encountered: