Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples still contain spurious xmlns declaration #2

Open
msdemlei opened this issue Jul 9, 2021 · 6 comments
Open

Examples still contain spurious xmlns declaration #2

msdemlei opened this issue Jul 9, 2021 · 6 comments

Comments

@msdemlei
Copy link

msdemlei commented Jul 9, 2021

SSAP used to require that people include a spurious XML prefix mapping for ssa
(the idea was to use that to somehow introduce some sort of versioning).
This was fortunately dropped in 1.1, but the examples in the appendix
still have

xmlns:ssa="http://www.ivoa.net/xml/DalSsap/v1.0"

Let's drop those.

jd-au added a commit to jd-au/SSA that referenced this issue Apr 17, 2023
@jd-au
Copy link
Member

jd-au commented Dec 4, 2023

I've created a draft erratum at https://wiki.ivoa.net/twiki/bin/view/IVOA/SSA-1_1-Err-3

@msdemlei
Copy link
Author

msdemlei commented Dec 5, 2023 via email

@mbtaylor
Copy link
Member

mbtaylor commented Dec 5, 2023

While I somewhat fear opening a can of worms by seeking to correct other things that are wrong in these examples (there are several including missing angle brackets, bad OPTION content, incorrect capitalization of RESOURCE type attribute values, ...) it would seem perverse to replace a line of VOTable with another line that is both incorrect and gratuitously confusing. So I support Markus's suggestion to replace all the VOTABLE start tags in the examples with

   <VOTABLE version="1.1" xmlns="http://www.ivoa.net/xml/VOTable/v1.1">

which is the minimal correct formulation for VOTable 1.1. I suggest that we don't update it to version 1.4, on the grounds that this is really a correction not an update, and I don't think we should give the impression that we're doing anything other than fixing (some) broken stuff.

The erratum text could include something like the additional sentence

[This Erratum] also makes some other corrections to the VOTABLE start tags, which in their previous formulation did not correctly set the namespace for the document elements.

(though you might be able to word that better)

@jd-au
Copy link
Member

jd-au commented Dec 8, 2023

Thanks for those suggestions - I've updated the new VOTABLE start tags and mentioned it in the rationale.

@mbtaylor
Copy link
Member

mbtaylor commented Dec 8, 2023

I removed some rogue "=" characters from your replacement XML; other than that, looks good to me.

@jd-au
Copy link
Member

jd-au commented Dec 8, 2023

Ah, I spotted the ones at the front, but not the back, of each example - must have come from the copy somehow! Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants