Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta.ref.ivorn : deprecated term still in list. #31

Closed
loumir opened this issue Jun 17, 2021 · 9 comments
Closed

meta.ref.ivorn : deprecated term still in list. #31

loumir opened this issue Jun 17, 2021 · 9 comments

Comments

@loumir
Copy link
Collaborator

loumir commented Jun 17, 2021

meta.ref.ivorn has been deprecated in previous version (UCDList1.3).

For consistency it should be removed from the current list .

cds tools allow to check deprecated terms and propose replacement .
question : should the deprecated list maintained at cds , uploaded to this git repo?
http://cdsweb.u-strasbg.fr/UCD/ucd1p-deprecated.txt

@msdemlei
Copy link
Contributor

msdemlei commented Jun 17, 2021 via email

@BaptisteCecconi BaptisteCecconi added this to the EN-1.5 milestone Jun 18, 2021
@gmantele
Copy link

I have been suggested to update a small library helping to check UCDs : Ucidy.

In this library/validator I use 2 files provided by this UCDList document: the PSV file with all IVOA recommended words and another one mapping the deprecated words and their suggested replacement. This latter is used by my library to give advice to users by suggesting him/her to use instead the recommended replacement word.

So what you say is that now I have to maintain this list by myself instead of relying of a file provided along the standard (anyway, was it of the standard?) ?

As far as I can see there is no new deprecated words in this new version. Is it correct?

@gmantele
Copy link

Anyway, using the updated list (UCD1+ 1.4) and the former deprecated mapping, my tests failed because of 2 UCD1+ words:

  • meta.ref.ivorn (as we just spoke about above)
  • pos.resolution

pos.resolution is apparently deprecated since UCD1+List 1.10. Is it normal it is back in? I possibly mis-interpreted all of that as I just scanned the document...I have not read it yet carefully.

@loumir
Copy link
Collaborator Author

loumir commented Jun 18, 2021 via email

@BaptisteCecconi
Copy link
Collaborator

BaptisteCecconi commented Jun 18, 2021

Hi @gmantele, I confirm that pos.resolution has been put back in the UCD list during UCDlist 1.3 RFM.

The new definition of pos.resolution is probably different from the initial one.

@BaptisteCecconi
Copy link
Collaborator

Shall we maintain the second list (deprecated terms and suggested replacements) in this repo, too ?

@gmantele
Copy link

I understand the reasons why @msdemlei would prefer not to do so. But as a consumer of these lists, it would be more safe if the authors of the UCD1+List maintain both lists, for the following reasons:

  • less risk of error when an implementation has to build itself the mapping,
  • and so less risk of divergence between implementations (though I think there are not many implementations for this second list),
  • it avoids ambiguity in case a deprecated word becomes no longer deprecated (as it happened here with pos.resolution).

This is why it would be more comfortable for me if both lists are officially maintained by the authors.

Now, if it is too risky/difficult for you, I can still adapt and build this list of deprecated words by myself every time a new version is released (which mean that I may ask a confirmation from time to time for some words...which is ok for me if it's ok for you).

However, please, still keep maintaining the list of official UCD1+ in a separated file as done currently (in this format or another)....this is really the most important for me.

@BaptisteCecconi
Copy link
Collaborator

ok, we can discuss this while preparing the next version.

About the ucd-list.txt file: the plan is to maintain it as it is now (as a separate file).

@loumir loumir added this to Done in bidon Sep 9, 2021
@loumir loumir moved this from Done to In progress in bidon Sep 9, 2021
@loumir loumir added this to To do in UCD list management Sep 9, 2021
@BaptisteCecconi
Copy link
Collaborator

The term has been removed from ucd-list.txt and has been included in ucd-list-deprecated.txt

UCD list management automation moved this from To do to Done May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
bidon
In progress
Development

No branches or pull requests

4 participants