Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UCDlist.tex #51

Merged
merged 7 commits into from
May 3, 2022
Merged

Update UCDlist.tex #51

merged 7 commits into from
May 3, 2022

Conversation

BaptisteCecconi
Copy link
Collaborator

First attempt to solve #35

msdemlei
msdemlei previously approved these changes May 3, 2022
Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my blessing for the changes (including when you back out my changes...)

@BaptisteCecconi
Copy link
Collaborator Author

BaptisteCecconi commented May 3, 2022

This PR describes the ucd-list.txt and ucd-list-deprecated.txt.
I'm not sure the way the ucd-list-deprecated.txt is defined is fully functional. So we should discuss this a bit more.

My current concern is, for instance, with the pos.resolution term, which has been first introduced in V1.01, then deprecated in v1.10, with a proposed replacement, but has been reintroduced (with another definition) in v1.4.

So currently, the term pos.resolution is both valid (as of v1.4) and deprecated (for previous versions).

On way to solve this would be to add 2 columns to the ucd-list-deprecated.txt: the UCD list version when it has been deprecated, and a date of deprecation. Then it might be possible for validators to compare dates of resources with date of deprecation.

@msdemlei
Copy link
Contributor

msdemlei commented May 3, 2022 via email

@BaptisteCecconi
Copy link
Collaborator Author

BaptisteCecconi commented May 3, 2022

yes, agreed from an operational point of view, that would be simpler. Older resources using pos.resolution (before it was deprecated, i.e., >=v1.01 and <v1.10) were using a different definition than that currently in place (>=v1.4). But that's not an operational issue, that's a resource maintenance issue.

removed `pos.resolution` from deprecated list, since it is not deprecated since v1.4.
Removed `meta.ref.ivorn`, since it is deprecated
@BaptisteCecconi
Copy link
Collaborator Author

I have fixed ucd-list.txt (removed meta.ref.ivorn) and ucd-list-deprecated.txt (removed pos.resolution).

@BaptisteCecconi
Copy link
Collaborator Author

NB: also solving #31

@loumir
Copy link
Collaborator

loumir commented May 3, 2022

good for cleaning meta.ref.ivorn out of ucd-list.txt.
the replacement rule is in the ucd-list-deprecated.txt.

my suggestion when we redefine the meaning of a former deprecated term:
It would be useful to have a #redefined status like :
#redefined : term new definition
pos.resolution '+' new definition
here
pos.resolution '+' Q | pos.resolution | Spatial linear resolution (not angular)
For those terms, the data providers need to check that they map the column to the most recent UCD definition, expressed here in the redefined list as a reminder .

drawback : the #redefined line should be exactly the same as in ucd-list.txt...
but this situation does not happen too often

Copy link
Collaborator

@loumir loumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with the useful description of the two lists added .

@loumir loumir merged commit 68c3031 into master May 3, 2022
@msdemlei
Copy link
Contributor

msdemlei commented May 3, 2022 via email

@BaptisteCecconi
Copy link
Collaborator Author

I agree with @msdemlei, the relevant information is available in the document humans. The plain text lists are for machines.

@BaptisteCecconi BaptisteCecconi deleted the BaptisteCecconi-patch-5 branch March 2, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants