Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change flag + definition meta.curation meta.email #39

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

loumir
Copy link
Collaborator

@loumir loumir commented Aug 26, 2021

meta.curation had P flag but SSA or Obscore implementations already use it in various combinations ( 22 occurrences in Gavo Registry).
Moving it to S for secondary word seems the least changes impacting running services.
meta.id;meta.curation is the replacement for current usage of meta.curation (12 occurrences in GAVO Registry ) to represent the name or id of curator/organisation
meta.email 's description, previously mentioning curation , is now defined more generally as 'Contact email'

_meta.curation_ had P flag but SSA or Obscore implementations already use it in various combinations ( 22 occurrences in Gavo Registry).
Moving it to S for secondary word seems the least changes impacting running services. 
meta.id;meta.curation is the replacement for current usage of meta.curation  (12 occurrences in GAVO Registry ) to represent the name or id of curator/organisation 
_meta.email_ 's description, previously mentioning curation , is now defined more generally as 'Contact email'
@loumir loumir linked an issue Aug 26, 2021 that may be closed by this pull request
@BaptisteCecconi BaptisteCecconi merged commit 8475122 into master Aug 26, 2021
Copy link
Member

@mbtaylor mbtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it wise to change from P to S? That means that if anybody was using it as Primary before, in accordance with the published standard, their usage will now be illegal. I suggest changing it to Q instead so that both old and new usages are legal.

@msdemlei
Copy link
Contributor

msdemlei commented Aug 30, 2021 via email

@loumir
Copy link
Collaborator Author

loumir commented Sep 1, 2021

Hi,
having Q for meta.curation make assigning tools fail when they have to decide how to combine
Q meta.mail
Q meta.curation
then which is first , which is second ?
the former use of meta.curation used as P , should be instead meta.id;meta.curation .
this is then not ambiguous anymore.
Vizier can update the former usage using a script .
May be the same could be done for other services .

@msdemlei
Copy link
Contributor

msdemlei commented Sep 2, 2021 via email

@loumir loumir deleted the loumir-metacuration+email branch May 5, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update of uCD list following SSAP UCD check
4 participants