RandomSampler fix to return correct sample size #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noted performance problems with high (~5000) key counts and traced it back to RandomSampler not effectively choosing a sample size. The above PR corrects this. |
ilikerobots
changed the title
|
Hi, thanks for this PR ! I don't know what I was thinking when I did this 😄 . It was obviously wrong... LGTM |
ivoleitao
approved these changes
Jul 18, 2021
|
I will do a release in the next weekend to fix this bug |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Correct the RandomSampler logic such that it returns a sample of the correct size.
Todos