Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy manifest #2045

Merged
merged 3 commits into from
May 4, 2024
Merged

Conversation

ujeon
Copy link
Contributor

@ujeon ujeon commented Apr 16, 2024

Add Privacy Manifest for File timestamp APIs, .creationDate & .modificationDate

add privacy manifest time stamp apis usage
add resource bundles to include PrivacyInfo as resource
@saraff13
Copy link

@ujeon Do we only need Photos and Videos to be defined? I tried adding this privacy file but it didn't worked.

@Maker-Mark
Copy link

This could close #2040 FYI

@ujeon
Copy link
Contributor Author

ujeon commented Apr 18, 2024

@saraff13

Are there any additional policies needed besides the Photo and Video policy? (just in my opinion, Apple make us somewhat confusing 🥲)

I'm having trouble understanding why adding a Privacy file didn't work, but could you mean there's an issue with the PDF generated from the archive?

@saraff13
Copy link

saraff13 commented Apr 18, 2024

@saraff13

Are there any additional policies needed besides the Photo and Video policy? (just in my opinion, Apple make us somewhat confusing 🥲)

I'm having trouble understanding why adding a Privacy file didn't work, but could you mean there's an issue with the PDF generated from the archive?

  1. In library setup we add NSPhotoLibraryUsageDescription, NSCameraUsageDescription, and NSMicrophoneUsageDescription. So we should add all privacy changes related to Photo, Video, and Audio as well.

  2. Yes, privacy report generated from archieve is giving error related to TOCropViewController that is being used as a dependency inside of RNImageCropPicker.

@ujeon
Copy link
Contributor Author

ujeon commented Apr 18, 2024

@saraff13
Are there any additional policies needed besides the Photo and Video policy? (just in my opinion, Apple make us somewhat confusing 🥲)
I'm having trouble understanding why adding a Privacy file didn't work, but could you mean there's an issue with the PDF generated from the archive?

  1. In library setup we add NSPhotoLibraryUsageDescription, NSCameraUsageDescription, and NSMicrophoneUsageDescription. So we should add all privacy changes related to Photo, Video, and Audio as well.
  2. Yes, privacy report generated from archieve is giving error related to TOCropViewController that is being used as a dependency inside of RNImageCropPicker.
  1. Do you have any reference for that? I have not recognized for that.

  2. Thanks, I've set the minimum TOCropViewController version to 2.7.0, which supports the privacy manifest. However, there seems to be an issue with TOCropViewController's privacy manifest (or something else).. I will open issue for that on TOCropViewController

@saraff13
Copy link

saraff13 commented Apr 18, 2024

@saraff13
Are there any additional policies needed besides the Photo and Video policy? (just in my opinion, Apple make us somewhat confusing 🥲)
I'm having trouble understanding why adding a Privacy file didn't work, but could you mean there's an issue with the PDF generated from the archive?

  1. In library setup we add NSPhotoLibraryUsageDescription, NSCameraUsageDescription, and NSMicrophoneUsageDescription. So we should add all privacy changes related to Photo, Video, and Audio as well.
  2. Yes, privacy report generated from archieve is giving error related to TOCropViewController that is being used as a dependency inside of RNImageCropPicker.
  1. Do you have any reference for that? I have not recognized for that.
  2. Thanks, I've set the minimum TOCropViewController version to 2.7.0, which supports the privacy manifest. However, there seems to be an issue with TOCropViewController's privacy manifest (or something else).. I will open issue for that on TOCropViewController
  1. Sorry, I couldn't find any reference. I was just checking possibility of failures.
  2. They have recently merged the fix in Privacy Manifest file. I think we will get a release soon. Once there is a release from TOCropViewController, This library will automatically pickup the latest version.

@saraff13
Copy link

@ujeon TOCropViewController version 2.7.3 is released.

TOCropViewController v2.7.3 supports privacy manifest
@ujeon ujeon force-pushed the chore/apple-privacy-manifest branch from 2c3e0a5 to 1e4bf65 Compare April 23, 2024 07:17
@ujeon
Copy link
Contributor Author

ujeon commented Apr 23, 2024

@saraff13 Thanks 👍 I did update min sdk to 2.7.3

Sorry, I couldn't find any reference. I was just checking possibility of failures.

I have worked based on required api scanner's "text-based scanner" and following the scanner's result, two required API .creationDate & .modificationDate are used.

(it just my opinion) This library requires NSPhotoLibraryUsageDescription, NSCameraUsageDescription, and NSMicrophoneUsageDescription, but it does not mean required apis are used. so I think that adding privacy manifest for just .creationDate & .modificationDate

@ujeon ujeon marked this pull request as ready for review April 24, 2024 08:42
@Maker-Mark
Copy link

@ivpusic can we get this merged and released?

@mateusdegobi
Copy link

@ivpusic can we get this merged and released?

please, I'm waiting for it

@ivpusic ivpusic merged commit 66984a2 into ivpusic:master May 4, 2024
@ivpusic
Copy link
Owner

ivpusic commented May 4, 2024

new version just relased. thanks for PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants