Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index_add #13559

Merged
merged 3 commits into from
Apr 10, 2023
Merged

index_add #13559

merged 3 commits into from
Apr 10, 2023

Conversation

kkaracam
Copy link
Contributor

Close #13557

@ivy-leaves ivy-leaves added PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Paddle Paddle Backend labels Mar 31, 2023
@ivy-leaves ivy-leaves added JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist labels Apr 1, 2023
@kkaracam
Copy link
Contributor Author

kkaracam commented Apr 1, 2023

@MahmoudAshraf97 looks like functions other than my implementation are failing. Could you please review?

MahmoudAshraf97
MahmoudAshraf97 suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove all changes that are unrelated to your implementation?

@kkaracam kkaracam closed this Apr 4, 2023
@kkaracam kkaracam reopened this Apr 4, 2023
@kkaracam
Copy link
Contributor Author

kkaracam commented Apr 4, 2023

Should be fine now, only lint check is failing

@MahmoudAshraf97 MahmoudAshraf97 removed their assignment Apr 6, 2023
sherry30
sherry30 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sherry30 sherry30 merged commit de0ce69 into ivy-llc:master Apr 10, 2023
VickyThawne pushed a commit to VickyThawne/ivy that referenced this pull request Apr 11, 2023
@kkaracam @sherry30 @VickyThawne
index_add (ivy-llc#13559)
fc62dbf 
Co-authored-by: sherry30 <sherrytst30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahmoudAshraf97 MahmoudAshraf97 MahmoudAshraf97 requested changes

@sherry30 sherry30 sherry30 approved these changes

@fspyridakos fspyridakos Awaiting requested review from fspyridakos

Assignees

@sherry30 sherry30

Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index_add
4 participants
@kkaracam @MahmoudAshraf97 @sherry30 @ivy-leaves