Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class_center_sample #21628

Closed
wants to merge 1 commit into from
Closed

class_center_sample #21628

wants to merge 1 commit into from

Conversation

teckno
Copy link
Contributor

@teckno teckno commented Aug 11, 2023

No description provided.

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@teckno teckno mentioned this pull request Aug 11, 2023
Open
16 tasks
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 11, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@teckno teckno mentioned this pull request Aug 18, 2023
Closed
fnhirwa
fnhirwa suggested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @teckno

Check the comments below

ivy/functional/frontends/paddle/nn/functional/common.py
@to_ivy_arrays_and_back
@with_supported_dtypes({"2.5.1 and below": ("float32", "float64")}, "paddle")
def class_center_sample ( label, num_classes, num_samples, group=None ):
return ivy.class_center_sample( label, num_classes, num_samples, group=group )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ivy doesn't have this function implemented on our API

ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_common.py
test_flags,
):
dtype, x, weight, bias = dtype_x_weight_bias
weight = ivy.swapaxes(weight, -1, -2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ivy dependency should be removed

@ivy-seed ivy-seed added the Stale label Oct 9, 2023
@ivy-seed
Copy link

ivy-seed commented Oct 9, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

@NripeshN NripeshN closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa requested changes

Assignees

@fnhirwa fnhirwa

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teckno @ivy-leaves @ivy-seed @fnhirwa @NripeshN