Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ivy creation.asarray for torch and tensorflow backend #28226

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

marvlyngkhoi
Copy link
Contributor

@marvlyngkhoi marvlyngkhoi commented Feb 8, 2024

PR Description

Passing local test for torch backend
Screenshot from 2024-02-09 01-36-15
Passing local test for tensorflow backend
Screenshot from 2024-02-09 01-39-19

Related Issue

Closes #28206
Closes #28225

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@marvlyngkhoi marvlyngkhoi changed the title Fix ivy creation.asarray for torch and tensorflow Fix ivy creation.asarray for torch and tensorflow backend Feb 8, 2024
@marvlyngkhoi marvlyngkhoi changed the title Fix ivy creation.asarray for torch and tensorflow backend fix ivy creation.asarray for torch and tensorflow backend Feb 11, 2024
@joaozenobio joaozenobio removed their assignment Feb 24, 2024
@NripeshN NripeshN merged commit 82ed332 into ivy-llc:main Feb 25, 2024
107 of 140 checks passed
Kacper-W-Kozdon pushed a commit to Kacper-W-Kozdon/ivy that referenced this pull request Feb 27, 2024
)

Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
@marvlyngkhoi marvlyngkhoi deleted the fix_ivy_creation_asarray branch March 1, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: tensorflow - creation.asarray Fix Ivy Failing Test: torch - creation.asarray
4 participants