Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: paddle - general_functions.tensorflow.clip_by_value #28668

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 23, 2024

PR Description

generalfunction clip_by_value
clip_by_value paddl

Paddle does not support some dtypes so handled that, not sure why complex is not supported, test were kinda flaky where sometimes jax passes and numpy fails or tensorflow passes and torch fails, all of them threw the same error (in the pic) saying complex is not supported, so added that to the unsupported dtypes.

Related Issue

Close #28664

This is also a drive by fix for
Close #28681

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Mar 23, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZJay07
Thanks for the PR.
I know you didn't specify float16 as unsupported in tf frontend clip_by_value funtion as it was already there but it does support float16
image

So maybe remove that. Otherwise all is good

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 26, 2024

Hmm this error was thrown when I tried removing float16 from the unsupported handle and passes with no error when it is included in the unsupported handle
image

@Ishticode
Copy link
Contributor

but that says "complex64" is not in supported dtypes. And it then lists the supported dtypes. You can see "half" listed in there which does refer to float16.

@ZJay07
Copy link
Contributor Author

ZJay07 commented Apr 2, 2024

Hey @Ishticode, just updated the fix, not sure why when I place complex it fails with the error above but when I specify complex64 and complex128 it passes without error

@ZJay07 ZJay07 requested a review from Ishticode April 2, 2024 17:12
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the fix.
I have seen this before. Although complex should automatically include both but there might be a bug that we should look into in the un/supported dtypes decorator. :)

@Ishticode Ishticode merged commit 7a0af13 into ivy-llc:main Apr 9, 2024
255 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Paddle Backend TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
3 participants