Added torch.ge and torch.greater_equal to the frontend
#3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjameskeane
suggested changes
Aug 26, 2022
| @@ -49,3 +49,11 @@ def eq(input, other, *, out=None): | |||
|
|
|||
| def argsort(input, dim=-1, descending=False): | |||
| return ivy.argsort(input, axis=dim, descending=descending) | |||
|
|
|||
|
|
|||
| def ge(input, other, *, out=None): | |||
There was a problem hiding this comment.
This is me being really picky but could you set greater_equal to be the main function and ge to be the alias. I think its more readable :)
There was a problem hiding this comment.
Yeah makes sense Let me do it I only implemented this way following torch implementation
| @@ -175,3 +175,44 @@ def test_torch_argsort( | |||
| dim=axis, | |||
| descending=descending, | |||
| ) | |||
|
|
|||
|
|
|||
| # ge | |||
iamjameskeane
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR resolves issues #3620 and #3621
These two functions
torch.geandtorch.greater_equalare aliases.Thanks