Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel unshuffle frontends pytorch #4145

Closed
wants to merge 3 commits into from
Closed

Pixel unshuffle frontends pytorch #4145

wants to merge 3 commits into from

Conversation

Prabhu-V
Copy link
Contributor

@Prabhu-V Prabhu-V commented Sep 7, 2022

simonetgordon
simonetgordon suggested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@simonetgordon simonetgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must undo changes to the 3 .idea files before I can merge.

@simonetgordon
Copy link
Contributor

simonetgordon commented Sep 7, 2022 •
edited
Loading

Hi there, thanks for the contribution 😊

As well as undoing changes to the .idea files, your changes have caused some lint issues:

ivy/functional/frontends/torch/vision_functions.py:69:6: E128 continuation line under-indented for visual indent
ivy/functional/frontends/torch/vision_functions.py:73:5: W292 no newline at end of file

Also, the test-frontend-torch check is failing for pixel_unshuffle. Check Details -> Run Frontend Test and then search for 'pixel_unshuffle' to see the error traceback to aid with debugging.

@simonetgordon simonetgordon added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 12, 2022
@simonetgordon
Copy link
Contributor

Hi @Prabhu-V, are you still working on this PR?

@Prabhu-V
Copy link
Contributor Author

Hi @Prabhu-V, are you still working on this PR?

@simonetgordon I am still working on the PR. Was having issue with test suite.

@Prabhu-V
Copy link
Contributor Author

Closing this pull request as it's duplicate of #4602 which was merged successfully

@Prabhu-V Prabhu-V closed this Sep 20, 2022
@Prabhu-V Prabhu-V deleted the pixel_unshuffle_frontends_pytorch branch September 20, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonetgordon simonetgordon simonetgordon requested changes

Assignees

@simonetgordon simonetgordon

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Prabhu-V @simonetgordon @sreegandh804 @ivy-leaves