Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic Agent Country Sales Report - Columns showing when no Data returned. #295

Closed
johnM2401 opened this issue Jun 23, 2021 · 4 comments
Closed
Assignees
Labels
bug Something isn't working S5 Sprint 5
Milestone

Comments

@johnM2401
Copy link

Describe the bug
When the Periodic Agent Country Sales report would show 0 results, it appears to show some of the Columns, rather than simply just "No Data Available"

**Component
What component does this bug relate to?

  1. Report - Periodic Agent Country Sales report

**Solution File
PeriodicAgentCountrySales.prpt

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the Periodic Agent Country Sales Report
  2. Set parameters so that 0 data is returned
  3. View the "No data available" screen

Expected behavior
Like other reports, there should be no Columns shown on the Report when no data is returned

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Browser: Firefox 88.0.1
@johnM2401 johnM2401 added bug Something isn't working S5 Sprint 5 labels Jun 23, 2021
@johnM2401 johnM2401 added this to the 1.4 milestone Jun 23, 2021
@harrisward
Copy link
Member

Added logic to hide this row when no data is returned

@harrisward
Copy link
Member

Feature Branch: https://github.com/ivylabs/suitecrm-analytics/tree/feature-295
Pull Request: #296

@harrisward
Copy link
Member

Please use the feature branch https://github.com/ivylabs/suitecrm-analytics/tree/feature-295. Once the fix has been confirmed I will merge the report into master @johnM2401

@harrisward harrisward assigned johnM2401 and unassigned harrisward Jun 24, 2021
@johnM2401 johnM2401 assigned harrisward and unassigned johnM2401 Jun 24, 2021
@johnM2401
Copy link
Author

Hey @harrisward
Looks good:
image

Can be merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working S5 Sprint 5
Projects
None yet
Development

No branches or pull requests

2 participants