Added check for number of paramters

iwalz · Jan 5, 2013 · c83ce7f · iwalz · Jan 5, 2013 · c83ce7f
1 parent f642ecf
commit c83ce7f
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 0 deletions.
diff --git a/library/Zend/Stdlib/Hydrator/ClassMethods.php b/library/Zend/Stdlib/Hydrator/ClassMethods.php
@@ -64,6 +64,11 @@ public function extract($object)
                 continue;
             }
 
+            $reflectionMethod = new \ReflectionMethod(get_class($object) . '::' . $method);
+            if ($reflectionMethod->getNumberOfParameters() > 0) {
+                continue;
+            }
+
             $attribute = $method;
             if (preg_match('/^get/', $method)) {
                 $attribute = substr($method, 3);

diff --git a/tests/ZendTest/Stdlib/HydratorTest.php b/tests/ZendTest/Stdlib/HydratorTest.php
@@ -15,6 +15,7 @@
 use ZendTest\Stdlib\TestAsset\ClassMethodsCamelCase;
 use ZendTest\Stdlib\TestAsset\ClassMethodsUnderscore;
 use ZendTest\Stdlib\TestAsset\ClassMethodsCamelCaseMissing;
+use ZendTest\Stdlib\TestAsset\ClassMethodsInvalidParameter;
 use ZendTest\Stdlib\TestAsset\Reflection as ReflectionAsset;
 
 /**
@@ -41,6 +42,11 @@ class HydratorTest extends \PHPUnit_Framework_TestCase
      */
     protected $classMethodsUnderscore;
 
+    /**
+     * @var ClassMethodsInvalidParameter
+     */
+    protected $classMethodsInvalidParameter;
+
     /**
      * @var ReflectionAsset
      */
@@ -51,6 +57,7 @@ public function setUp()
         $this->classMethodsCamelCase = new ClassMethodsCamelCase();
         $this->classMethodsCamelCaseMissing = new ClassMethodsCamelCaseMissing();
         $this->classMethodsUnderscore = new ClassMethodsUnderscore();
+        $this->classMethodsInvalidParameter = new ClassMethodsInvalidParameter();
         $this->reflection = new ReflectionAsset;
     }
 
@@ -203,4 +210,10 @@ public function testHydratorClassMethodsCamelCaseWithSetterMissing()
         $this->assertEquals($test->getFooBar(), 'foo');
         $this->assertEquals($test->getFooBarBaz(), '2');
     }
+
+    public function testHydratorClassMethodsWithServiceManager()
+    {
+        $hydrator = new ClassMethods(false);
+        $datas = $hydrator->extract($this->classMethodsInvalidParameter);
+    }
 }
diff --git a/tests/ZendTest/Stdlib/TestAsset/ClassMethodsInvalidParameter.php b/tests/ZendTest/Stdlib/TestAsset/ClassMethodsInvalidParameter.php
@@ -0,0 +1,18 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link      http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ * @package   Zend_Stdlib
+ */
+namespace ZendTest\Stdlib\TestAsset;
+
+class ClassMethodsInvalidParameter
+{
+    public function hasAlias($alias)
+    {
+        return $alias;
+    }
+}