Support for ISO 14230-2 KWP #12
Conversation
| @@ -70,7 +70,7 @@ typedef struct{ | |||
| } obd_unit; | |||
|
|
|||
| typedef struct{ | |||
| uint32_t old_value; | |||
| int32_t old_value; | |||
There was a problem hiding this comment.
One small unrelated fix to ensure that clearing the previous number doesn't break when a negative number was displayed, such as low temperatures.
| @@ -57,7 +57,7 @@ | |||
| // The ECU might not push all bytes on the bus immediately, but wait several ms | |||
| // between the bytes, this is the time allowed per byte for the answer | |||
|
|
|||
| #define OBD9141_WAIT_FOR_REQUEST_ANSWER_TIMEOUT (30 + 10) | |||
| #define OBD9141_WAIT_FOR_REQUEST_ANSWER_TIMEOUT (30 + 20) | |||
There was a problem hiding this comment.
Slight increase in this timeout, KWP may require some different timing. In normal operation the code never reaches this timeout so it doesn't negatively affect any successful operation because we return after reading all the expected bytes.
|
@mjs513, this functionality was in large part made possible by your efforts in testing my code. I enjoyed the quick back and forths we did on #11. Thanks for the collaboration and your help in improving this library! If you have any last comments before this is merged with |
|
@iwanders. Sorry for the delay in getting back to you. I agree I had a lot fun working on this with you testing the code changes. I really don't have anything else to add before you do the merge. An no I do not need any explicit callout in the readme. But thanks for offering. Mike |
This adds the ISO 14230-2 KWP support to the
masterbranch. Confirmed today that the 9141-2 functionality on this branch is unaffected using the Display example. This closes #11, closes #5