[cmark] Some characters are escaped twice

[krummler]

First off, thanks for this great library!

• I've searched other open/closed issues for duplicates before opening up this new issue.

Report

What did you do?

Entered multiple html-excaped characters into the content of a DownView

What did you expect to happen?

I expect characters to be rendered like their unescaped counterparts, for example:

• & becomes &
• " becomes "
• < becomes <

What happened instead?

Most characters seem to work fine, except for > and < (maybe there are more cases).

• & stays & which renders as &
• " stays " which renders as "
• < becomes < which renders as <
• > becomes > which renders as >

[iwasrobbed]

Thanks for filing this @krummler; this is an issue in the underlying cmark lib. We are using the stable version 0.28.3 so you'd need to file a feature request in the cmark repo.

Confirmed

& Hello\n\n" Hai\n\n< Does that work\n\n> Maybe

becomes

"<p>&amp; Hello</p>\n<p>&quot; Hai</p>\n<p>&amp;lt; Does that work</p>\n<p>&amp;gt; Maybe</p>\n"

[krummler]

Hi Rob,

I made an issue: commonmark/cmark#276. I'll report back if there are any significant changes.

[phoney]

They deny they can reproduce this on the cmark project in that issue#276. The date that 0.28.3 PR was merged into Down is the same day as @iwasrobbed 's comments above (it says 18 days ago). When I attempt to reproduce this with Down 0.6.1 it seems to work correctly. I get

<p>&amp; Hello</p>\n<p>&quot; Hai</p>\n<p>&lt; Does that work</p>\n<p>&gt; Maybe</p>

which I think is correct. Is it possible this was fixed in the cmark update? Actually, I just checked and this bug is present in 0.5.2 and absent in 0.6.0 and later. So I think it's fixed.

[iwasrobbed]

Thanks for checking @phoney! Please verify with the latest Down release and re-open this issue if it continues. It might just be an encoding issue if so @krummler

[krummler]

Hi there, thanks for the feedback, it seems to work fine now!