Culture specific bugs are fixed. All tests are "green" now. #7
Conversation
|
Hi @psmolich79 ! Thank you for your contribute! I check your code and it looks good :) However, I want to know what values cause error. Would you add a few test cases specific values ? |
|
Hi @iwate please consider to merge this pull request, as it fixes formatting problems on non english systems. |
| @@ -57,7 +57,8 @@ public static Request Create<T>(HttpMethod method, string uri, T body, IEnumerab | |||
|
|
|||
| if (type.IsValueType || type == stringType) | |||
| { | |||
| content = body.ToString(); | |||
| //content = body.ToString(); | |||
There was a problem hiding this comment.
This need plain text, so we cannot use json serializer.
|
@bxbxbx Thank you for your comments. I understand this current culture issue but I cannot merge this PR because this patch has a many changes from current master. I've added red pattern test codes for this issue. (597337a) If @psmolich79 could modify and recreate this PR, I merge it. When this PR is not update until next weekend, I create a patch by self and close this PR. |
There was a problem hiding this comment.
@psmolich79 Thank you modify PR.
However, this change includes a change that reverts to the old code.
Could you re-create it including only your changes?
If it is difficult, you can create new a branch from current master and create new a PR.
| } | ||
| else if (type.IsValueType) | ||
| { | ||
| content = serializer.Serialize<T>(body); |
There was a problem hiding this comment.
This request content type is needed plain text whichi cannnot use serializer. use ToString with CultureInfo.InvariantCulture.
| @@ -16,10 +14,8 @@ public class Response | |||
| public string MediaType { get; private set; } | |||
| public string ErrorMessage { get; private set; } | |||
| public byte[] Binary { get; private set; } | |||
| public string Body { get => GetStringFromUTF8(Binary); } | |||
There was a problem hiding this comment.
GetStringFromUTF8 is needed for BOM
|
This issue is resolved at #24 |
Fixed problems related to culture and proper conversions.