Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build source code #3

Open
java-james opened this issue Jan 19, 2023 · 1 comment
Open

Build source code #3

java-james opened this issue Jan 19, 2023 · 1 comment

Comments

@java-james
Copy link
Contributor

java-james commented Jan 19, 2023

Currently getting tsc issues depending on this project. #2
addresses the issues experienced however, if the code is transpired and then published it will avoid the issue happening again in the future.

The library should be published with a /lib directory containing the javascript and type definitions. The package can reference this directory as the entry file and /src can then be excluded from the artefact published to npm.

Either tsc or a bundling tool like webpack/esbuild/rollup can help achieve this

@iway1
Copy link
Owner

iway1 commented Jan 21, 2023

Yeah I'd agree that'd be a lot better -

I'm currently not maintaining this library b/c I just don't have time. Feel free to open a PR (or just copy / paste the code into your own project if that's easier).

Going to add a note that this library is not actively maintained to the docs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants