feat: export style type #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java-james
commented
Jan 19, 2023
| @@ -36,6 +36,7 @@ | |||
| "lodash": "^4.17.21" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/react-native": "^0.69.5" | |||
| "@types/react-native": "^0.69.5", | |||
| "@types/lodash": "^4.14.191" | |||
There was a problem hiding this comment.
Published /package is using loadash and requires types for tsc
java-james
commented
Jan 19, 2023
| import React, { useState } from "react"; | ||
| import { Image, ImageBackground, ScrollView, StyleSheet, Text, View, ViewProps } from "react-native"; | ||
| import { GradientBorderView } from "./package/index"; | ||
| import MaskedView from '@react-native-masked-view/masked-view'; |
There was a problem hiding this comment.
removed unused imports and remainder is format by prettier
java-james
commented
Jan 19, 2023
| | 'borderBottomColor' | ||
| >; | ||
|
|
||
| export type GradientBorderViewStyle = StyleProp< |
There was a problem hiding this comment.
Added style type
java-james
commented
Jan 19, 2023
| import React from "react"; | ||
| import { StyleProp, StyleSheet, View, ViewProps, ViewStyle } from "react-native"; | ||
| import GradientBorder, { RequiredGradientBorderProps } from "./GradientBorder"; | ||
| import React from 'react'; |
There was a problem hiding this comment.
Removed unused imports, added style type, remainder is formatting from prettier
java-james
commented
Jan 19, 2023
| import { StyleSheet, View, ViewStyle } from "react-native" | ||
| import MaskedView from "@react-native-masked-view/masked-view" | ||
| import LinearGradient, { LinearGradientProps } from "react-native-linear-gradient" | ||
| import React from 'react'; |
There was a problem hiding this comment.
Formatting changes from prettier only
Open
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few commits intended to be squash merged.
Edits welcome. Applied quite quickly so do review please.
Addresses #1