Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vault #112

Merged
merged 2 commits into from Oct 1, 2020
Merged

Add Vault #112

merged 2 commits into from Oct 1, 2020

Conversation

marblenix
Copy link
Contributor

Adds hashicorp's vault service

  1. Add the entry to INDEX in alphabetical order ✔️
  2. Includes a new icon in the ./icon/ directory ✔️
  3. Ensure the submitted icon file is a valid PNG that is 128x128 in size ✔️

@kmoore134 kmoore134 self-requested a review October 1, 2020 17:59
INDEX Outdated Show resolved Hide resolved
@kmoore134 kmoore134 merged commit b1b785f into ix-plugin-hub:master Oct 1, 2020
@kmoore134
Copy link
Contributor

Oh, as a follow-up. Did you intend to use "release": "11.3-RELEASE", or will 12.1-RELEASE work for the upcoming 12.1-RELEASE packages?

@marblenix
Copy link
Contributor Author

I was only able to test 11.3-RELEASE locally because of my freenas version; but I believe it should work with 12.1 out of the box.

@fulder
Copy link
Contributor

fulder commented Oct 1, 2020

I just tested running it inside a 12.1 jail in a TrueNAS Core system. Looks like the installation is working fine :) Just one small thing. The service is not automatically started after the installation, so maybe something to add to the post_install.sh script. After manually starting it, I could reach the UI without any problems.

@fulder
Copy link
Contributor

fulder commented Oct 1, 2020

Also there seems to be a small bug in the ui.json as the Admin Portals value for this plugin became http://192.168.1.193:"0.0.0.0:8200"/ui/ after the installation (probably because the port value in the vault.json is 0.0.0.0:8200).

@marblenix
Copy link
Contributor Author

@fulder
thanks for testing that for me! new code with bugfixes should be live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants