Merge pull request #240 from ixartz/refactor-route

refactor: route handler, make it easier to understand
ixartz · Jan 21, 2024 · e3c5458 · e3c5458
2 parents 69e78bc + e86f548
commit e3c5458
Showing 1 changed file with 36 additions and 46 deletions.
diff --git a/src/app/[locale]/(unauth)/api/guestbook/route.ts b/src/app/[locale]/(unauth)/api/guestbook/route.ts
@@ -1,6 +1,5 @@
 import { eq, sql } from 'drizzle-orm';
 import { NextResponse } from 'next/server';
-import { z } from 'zod';
 
 import { db } from '@/libs/DB';
 import { guestbookSchema } from '@/models/Schema';
@@ -11,64 +10,55 @@ import {
 } from '@/validations/GuestbookValidation';
 
 export const POST = async (request: Request) => {
-  try {
-    const json = await request.json();
-    const body = GuestbookValidation.parse(json);
+  const json = await request.json();
+  const parse = GuestbookValidation.safeParse(json);
 
-    const guestbook = await db.insert(guestbookSchema).values(body).returning();
+  if (!parse.success) {
+    return NextResponse.json(parse.error.format(), { status: 422 });
+  }
 
-    return NextResponse.json({
-      id: guestbook[0]?.id,
-    });
-  } catch (error) {
-    if (error instanceof z.ZodError) {
-      return NextResponse.json(error.format(), { status: 422 });
-    }
+  const guestbook = await db
+    .insert(guestbookSchema)
+    .values(parse.data)
+    .returning();
 
-    return NextResponse.json({}, { status: 500 });
-  }
+  return NextResponse.json({
+    id: guestbook[0]?.id,
+  });
 };
 
 export const PUT = async (request: Request) => {
-  try {
-    const json = await request.json();
-    const body = EditGuestbookValidation.parse(json);
+  const json = await request.json();
+  const parse = EditGuestbookValidation.safeParse(json);
 
-    await db
-      .update(guestbookSchema)
-      .set({
-        ...body,
-        updatedAt: sql`(strftime('%s', 'now'))`,
-      })
-      .where(eq(guestbookSchema.id, body.id))
-      .run();
+  if (!parse.success) {
+    return NextResponse.json(parse.error.format(), { status: 422 });
+  }
 
-    return NextResponse.json({});
-  } catch (error) {
-    if (error instanceof z.ZodError) {
-      return NextResponse.json(error.format(), { status: 422 });
-    }
+  await db
+    .update(guestbookSchema)
+    .set({
+      ...parse.data,
+      updatedAt: sql`(strftime('%s', 'now'))`,
+    })
+    .where(eq(guestbookSchema.id, parse.data.id))
+    .run();
 
-    return NextResponse.json({}, { status: 500 });
-  }
+  return NextResponse.json({});
 };
 
 export const DELETE = async (request: Request) => {
-  try {
-    const json = await request.json();
-    const body = DeleteGuestbookValidation.parse(json);
+  const json = await request.json();
+  const parse = DeleteGuestbookValidation.safeParse(json);
 
-    await db
-      .delete(guestbookSchema)
-      .where(eq(guestbookSchema.id, body.id))
-      .run();
+  if (!parse.success) {
+    return NextResponse.json(parse.error.format(), { status: 422 });
+  }
 
-    return NextResponse.json({});
-  } catch (error) {
-    if (error instanceof z.ZodError) {
-      return NextResponse.json(error.format(), { status: 422 });
-    }
+  await db
+    .delete(guestbookSchema)
+    .where(eq(guestbookSchema.id, parse.data.id))
+    .run();
 
-    return NextResponse.json({}, { status: 500 });
-  }
+  return NextResponse.json({});
 };