Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add next-i18next #39

Closed
wants to merge 2 commits into from
Closed

add next-i18next #39

wants to merge 2 commits into from

Conversation

JaeMeDev
Copy link

You can test by accessing /en/about and /ko/about.

https://github.com/isaachinman/next-i18next

@ixartz
Copy link
Owner

ixartz commented May 27, 2022

Hi @JaeMeDev, thank you for creating this PR. This feature is indeed asked by several people: #13

My concern is about next-i18next, it relies on Next.js Internationalized Routing: https://nextjs.org/docs/advanced-features/i18n-routing
And, this feature will break the support for next export.

Is it correct? I have never tried it.

@ixartz ixartz added the question Further information is requested label May 27, 2022
@JaeMeDev JaeMeDev closed this Jun 10, 2022
@harrybawsac
Copy link

harrybawsac commented Jun 18, 2022

Yes, you're right. It does break next export. It doesn't matter whether you use react-intl or next-i18next or any of the other packages, the base will always be the i18n stuff from next itself. And that will always break.

I'd just say: "screw next export". You already have getStaticProps anyways. Also, when you drop support for export, you'd gain support for tools like /api, image optimalization and other things.

@ixartz
Copy link
Owner

ixartz commented Jun 19, 2022

@harrybawsac, thank you for taking to share your experience. What about not to rely on next.js for i18n? Just rely on classic react i18n package.

Currently both are supported export and non export. So, you can still enjoy /api, image optimization and other things.

@harrybawsac
Copy link

Seems a bit like a roundabout way when Next has i18n stuff already build in.

Also, I get this nasty feeling how everything within the i18next ecosystem is nudging developers towards using Locize.com.

@ixartz
Copy link
Owner

ixartz commented Jun 19, 2022

Haha, I have exactly the same feeling with Next.js and Vercel: the latest Next.js release are more targeting Vercel users.

@comverser comverser mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants