Allow playlist render if a track is no longer streamable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjdines
pushed a commit
that referenced
this pull request
Feb 3, 2015
Allow playlist render if a track is no longer streamable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows streamable tracks to be rendered as normal.
Example: https://api.soundcloud.com/tracks/151776364 (add
consumer_keywhencurl'ing) "Two Tone Melody" exists in MC's playlist but is no longer streamable. When line 23 tries to.match()there is nostream_urlpresent in the JSON response, throwing an exception that prevents the playlist from rendering.@Aramgutang: could you please review?