-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ms_plotter works #176
Open
AlexanderKrabbe
wants to merge
19
commits into
ixdat:units
Choose a base branch
from
AlexanderKrabbe:units
base: units
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ms_plotter works #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y. This cannot be done closer to the dataseries since the measurement owns the dataseries and not referencing the dataseries?
… subsequent derivatives e.i grab fluxes for siq
…f changing data in ixdat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ms_plotter works
ms_plotter.vs() needs some clean up
The main thing is how pint lets you set a matplotlib formatter for the units, so when axes are passed on, the label dynamically updates if the unit of the axes shoul change:
ax = meas_ms.plot()
ax.yaxis.get_unit() -> "A"
ax.yaxis.set_units(ureg.nA)
plt.plot()
data is correctly plotted
There is a nice thing about pint with their class Context.
This class could be a nice way to provide context for the measurement when units changes from mol/s to mol/s/cm^2