Skip to content

ixmanuel/hangman

 
 

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

31 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Build Status

Hangman is a words guessing game for one player. The computer guesses a word and the user has to suggest letters one by one. Every time the word contains a letter, the computer opens it (all of them, if there are a few). Every time the word doesn't contain a letter, the computer gives a penalty point for the user. If there are five penalty points, the user looses. If there are no hidden letters anymore, the computer looses.

Pull request

  • Without:

    • a single private method;
    • parameters in methods (except for out.display(label));
    • Null;
    • public constants;
    • Getters/Setters;
    • Inheritance;
    • Traits or mixins;
    • Static methods;
    • MVC but an event model;
    • If-Then-Else but an event model;
    • DTO;
    • Singleton;
    • Annotations;
    • Class casting;
    • Utility classes.
  • With:

    • Naming accordingly with the EO1 approach.
    • Unique objects;
    • Just composition;
    • Decorating envelopes;
    • Encapsulation;
    • Inmmutability;
    • Final classes;
    • Vertical descomposition;
    • Configurable by composition without coupling (except for IfBase and OnBase);
    • A modified printer;
    • Validating decorators;
    • An "ugly" view in hangman.Attempt, but you can see at a glance the architecture;
    • One primary constructors;
    • Code-free constructors. Thus, the code is declarative;
    • Contract-oriented programing;
  • Without following:

    • Multiple returns (I don't understad why it is a code smell);
    • Compound names in vars, but very balanced.
    • Empty lines. I let empty lines between state, constructors and methods.
  • Todo:

    • Removing new in methods.
    • Caching and improving the algorithms.
    • Write identified Tests in TestPlan.md

First, build it:

$ mvn clean package

Then, run:

$ java -classpath target/classes hangman.Main

It is not object-oriented

This Java code is very procedural, imperative and not elegant at all.

Please, try to refactor it and improve. You're welcome to create new classes, new methods, anything. Just make sure it still builds.

When ready, please submit a pull request.

License

The MIT License (MIT)

Copyright (c) 2017 Yegor Bugayenko

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Releases

No releases published

Packages

No packages published

Languages

  • Java 100.0%