Skip to content

Commit

Permalink
fix: Clarify that scope of qualifier
Browse files Browse the repository at this point in the history
  • Loading branch information
ixti committed Dec 12, 2023
1 parent f42bb14 commit 71c0ae1
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ kill::
Kill the job (send to the dead set instead of enqueueing and/or performing)


=== Qualifiers
=== Class Qualifiers

Qualifier is the job class pattern. It may match the job class or the job class
and method name (when used with ActionMailer delayed deliveries):
Class qualifier is the job class pattern. It may match the job class or the job
class and method name (when used with ActionMailer delayed deliveries):

* `ExampleJob`
* `Namespaced::ExampleJob`
Expand Down
2 changes: 1 addition & 1 deletion spec/sidekiq/antidote/web_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def csrf_token

expect(page)
.to have_current_path("/antidote/add")
.and have_css("#antidote-inhibitor-qualifier-error")
.and have_css("#antidote-inhibitor-class-qualifier-error")
end
end

Expand Down
2 changes: 1 addition & 1 deletion web/locales/en.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
en:
antidote.treatment: Treatment
antidote.qualifier: Qualifier
antidote.class_qualifier: Class Qualifier
antidote.actions: Actions
antidote.add: Add Inhibitor
antidote.add.submit: Submit
Expand Down
6 changes: 3 additions & 3 deletions web/views/add.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
</div>
</div>
<div class="form-group <%= "has-error" if @class_qualifier_error %>">
<label class="col-sm-2 control-label"><%= t("antidote.qualifier") %></label>
<label class="col-sm-2 control-label"><%= t("antidote.class_qualifier") %></label>
<div class="col-sm-10">
<input id="antidote-inhibitor-qualifier" type="text" class="form-control <%= "is-invalid" if @class_qualifier_error %>" name="class_qualifier" value="<%= @class_qualifier %>">
<input id="antidote-inhibitor-class-qualifier" type="text" class="form-control <%= "is-invalid" if @class_qualifier_error %>" name="class_qualifier" value="<%= @class_qualifier %>">
<% if @class_qualifier_error %>
<div id="antidote-inhibitor-qualifier-error" class="help-block">
<div id="antidote-inhibitor-class-qualifier-error" class="help-block">
<strong>ERROR:</strong> <%= @class_qualifier_error %>
</div>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion web/views/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<table class="antidote table table-hover table-bordered table-striped">
<thead>
<th><%= t("antidote.treatment") %></th>
<th><%= t("antidote.qualifier") %></th>
<th><%= t("antidote.class_qualifier") %></th>
<th><%= t("antidote.actions") %></th>
</thead>
<tbody>
Expand Down

0 comments on commit 71c0ae1

Please sign in to comment.