Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid/ Missing register writes in ixgbe driver #29

Closed
Ramla-I opened this issue Sep 25, 2023 · 1 comment
Closed

Invalid/ Missing register writes in ixgbe driver #29

Ramla-I opened this issue Sep 25, 2023 · 1 comment

Comments

@Ramla-I
Copy link

Ramla-I commented Sep 25, 2023

The following bugs are present in the ixgbe driver:

  1. Write to reserved bit 31 of EIMC register in the clear_interrupts function
  2. Write to reserved bits [15:12] of the DTXMXSZRQ register
  3. Bits of RDRXCTL are not set by software. According to the datasheet:
    RDRXCTL.RSCFRSTSIZE is by default 0x8 and should be set to 0 by software.
    RDRXCTL.RSCACKC is by default 0 and should be set to 1 by software.
    RDRXCTL.FCOE_WRFIX is by default 0 and should be set to 1 by software.
  4. The FCTRL register should only be modified/ updated when the RXCTRL.RXEN bit is set to 0, but the set_promisc function updates the filters after RXCTRL.RXEN is set.
@ackxolotl
Copy link
Member

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants