Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy parameter policy_params["soz_vers_beitr"]["beitr_satz"]["ges_pflegev"]["standard"] is wrong for 2022 #373

Closed
JuergenWiemers opened this issue Apr 8, 2022 · 3 comments · Fixed by #377
Labels
bug Something isn't working

Comments

@JuergenWiemers
Copy link
Collaborator

The policy parameter policy_params["soz_vers_beitr"]["beitr_satz"]["ges_pflegev"]["standard"] is wrong for 2022

Minimal code example:

import numpy as np
import pandas as pd
from gettsim import set_up_policy_environment
from gettsim.config import ROOT_DIR

for year in range(2016, 2023):
    policy_params, policy_functions = set_up_policy_environment(date=f"{year}-01-01")
    print(year, policy_params["soz_vers_beitr"]["beitr_satz"]["ges_pflegev"]["standard"])

The parameter for 2022 should be 0.01525, not 0.01175.

@JuergenWiemers JuergenWiemers added the bug Something isn't working label Apr 8, 2022
@hmgaudecker
Copy link
Collaborator

Have not checked correctness, but I'd trust you on this one!

No need for a code example in this case.

Would you mind starting the Pull Request? Probably just a matter of changing that one number in the YAML file. If tests need adjustment, I'd be happy to look into that.

@JuergenWiemers
Copy link
Collaborator Author

O.k., I'm going to try this. My first pull request (ever)!

@hmgaudecker
Copy link
Collaborator

O.k., I'm going to try this. My first pull request (ever)!

And it might have set the record for the most quickly merged PR in GETTSIM right away. Great job! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants