Release 0.3.1 and skip and emit warning if gettsim.test() is repeatedly called. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasraabe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 95.43% 95.25% -0.18%
==========================================
Files 54 54
Lines 1555 1561 +6
==========================================
+ Hits 1484 1487 +3
- Misses 71 74 +3
Continue to review full report at Codecov.
|
hmgaudecker
approved these changes
Jun 5, 2020
tobiasraabe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
Repeatedly calling
gettsim.test()is not possible because there seems to be some state dependence.Solution
Skip all other calls to the function except the first and emit a warning.