Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update policy for date #196

Merged
merged 17 commits into from Jun 15, 2020
Merged

Update policy for date #196

merged 17 commits into from Jun 15, 2020

Conversation

MaxBlesch
Copy link
Collaborator

@MaxBlesch MaxBlesch commented Jun 14, 2020

What problem do you want to solve?

The docstrings in policy_for_date.py are either incomplete or not existent. I will complete the docstrings and refactor the code to have a more readable structure.

Todo

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #196 into master will decrease coverage by 0.49%.
The diff coverage is 83.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   95.25%   94.76%   -0.50%     
==========================================
  Files          54       54              
  Lines        1561     1584      +23     
==========================================
+ Hits         1487     1501      +14     
- Misses         74       83       +9     
Impacted Files Coverage Δ
gettsim/tests/test_arbeitsl_geld.py 100.00% <ø> (ø)
gettsim/tests/test_arbeitsl_geld_2.py 100.00% <ø> (ø)
gettsim/tests/test_benefit_checks.py 100.00% <ø> (ø)
gettsim/tests/test_eink_st.py 100.00% <ø> (ø)
gettsim/tests/test_elterngeld.py 100.00% <ø> (ø)
gettsim/tests/test_favorability_check.py 100.00% <ø> (ø)
gettsim/tests/test_kindergeld.py 100.00% <ø> (ø)
gettsim/tests/test_kinderzuschlag.py 100.00% <ø> (ø)
gettsim/tests/test_soli_st.py 100.00% <ø> (ø)
gettsim/tests/test_soz_vers.py 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bfbeed...369e2e2. Read the comment docs.

Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Max, here is my preliminary review. I will review after the changes are discussed and maybe implemented.

gettsim/pre_processing/policy_for_date.py Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! 👍 There are a lot of small improvements, enhanced readability, etc..

gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Show resolved Hide resolved
gettsim/pre_processing/policy_for_date.py Outdated Show resolved Hide resolved
gettsim/tests/test_arbeitsl_geld_2.py Outdated Show resolved Hide resolved
gettsim/tests/test_benefit_checks.py Outdated Show resolved Hide resolved
@MaxBlesch MaxBlesch merged commit defb9a8 into master Jun 15, 2020
@MaxBlesch MaxBlesch deleted the update_policy_for_date branch June 15, 2020 09:11
@tobiasraabe tobiasraabe added this to the v0.3.2 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants