New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update policy for date #196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 95.25% 94.76% -0.50%
==========================================
Files 54 54
Lines 1561 1584 +23
==========================================
+ Hits 1487 1501 +14
- Misses 74 83 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Max, here is my preliminary review. I will review after the changes are discussed and maybe implemented.
Co-authored-by: Tobias Raabe <raabe@posteo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR! 👍 There are a lot of small improvements, enhanced readability, etc..
Co-authored-by: Tobias Raabe <raabe@posteo.de>
What problem do you want to solve?
The docstrings in
policy_for_date.py
are either incomplete or not existent. I will complete the docstrings and refactor the code to have a more readable structure.Todo
get_policies_for_date
.jahr
and switch completely todatum
.