New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document functions which build the tax and transfer system. #197
Conversation
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 94.54% 94.66% +0.11%
==========================================
Files 54 56 +2
Lines 1613 1649 +36
==========================================
+ Hits 1525 1561 +36
Misses 88 88
Continue to review full report at Codecov.
|
Again, maybe it got lost somewhere: I'd love to have a full list of all functions as they appear in a graph, without the path prefix or grouping. Any chance to achieve that? |
@hmgaudecker I think I have done what you wanted. I am not kidding this was one of the hardest issues with gettsim. You see that my solution combines two sphinx extensions and I reviewed even more. I really hope that's it :). There are two functions which do not have a one-liner describing the functions, but a parameter entry. Thus they have this blue line in the table. Could you, @MaxBlesch, quickly add appropriate one-liners? |
Co-authored-by: Hans-Martin <hmgaudecker@gmail.com>
Co-authored-by: Hans-Martin <hmgaudecker@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Last minute: We are missing things that are disambiguated because the functions change over time. E.g., "vorsorge" does not appear and I had a hard time finding it... Any ideas on how to include these? or should we just make the underlying functions public? |
a) Make naming consistent. b) Remove leading underscores so that they show up in the docs.
Alright, I hope this solves it. We should not rename all things to be public. But those that are disambiguated in |
@hmgaudecker Merge? |
What problem do you want to solve?
Display all internal functions in one document in the docs
Note that private functions are not displayed in the tables generated by autosummary, but are still documented below. We postpone making all functions public, to not break any functionality for the university course.
Resolves #194.