Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document functions which build the tax and transfer system. #197

Merged
merged 46 commits into from Jun 18, 2020
Merged

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jun 15, 2020

What problem do you want to solve?

Display all internal functions in one document in the docs

Note that private functions are not displayed in the tables generated by autosummary, but are still documented below. We postpone making all functions public, to not break any functionality for the university course.

Resolves #194.

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #197 into master will increase coverage by 0.11%.
The diff coverage is 98.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   94.54%   94.66%   +0.11%     
==========================================
  Files          54       56       +2     
  Lines        1613     1649      +36     
==========================================
+ Hits         1525     1561      +36     
  Misses         88       88              
Impacted Files Coverage Δ
gettsim/benefits/arbeitsl_geld.py 95.65% <ø> (ø)
...ettsim/benefits/arbeitsl_geld_2/arbeitsl_geld_2.py 100.00% <ø> (ø)
gettsim/benefits/elterngeld.py 95.31% <ø> (ø)
gettsim/benefits/unterhalt.py 100.00% <ø> (ø)
gettsim/benefits/wohngeld.py 100.00% <ø> (ø)
gettsim/dag.py 88.13% <0.00%> (ø)
gettsim/demographic_vars.py 97.36% <ø> (ø)
gettsim/soz_vers/arbeitsl_v_rentenv.py 100.00% <ø> (ø)
gettsim/soz_vers/eink_grenzen.py 100.00% <ø> (ø)
gettsim/taxes/abgelt_st.py 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c609fd...64fcc18. Read the comment docs.

@tobiasraabe tobiasraabe self-assigned this Jun 15, 2020
@tobiasraabe tobiasraabe added this to the v0.3.2 milestone Jun 16, 2020
@tobiasraabe tobiasraabe mentioned this pull request Jun 16, 2020
docs/functions.rst Show resolved Hide resolved
docs/functions.rst Outdated Show resolved Hide resolved
docs/functions.rst Outdated Show resolved Hide resolved
@hmgaudecker
Copy link
Collaborator

Again, maybe it got lost somewhere: I'd love to have a full list of all functions as they appear in a graph, without the path prefix or grouping. Any chance to achieve that?

@tobiasraabe
Copy link
Member Author

@hmgaudecker I think I have done what you wanted. I am not kidding this was one of the hardest issues with gettsim. You see that my solution combines two sphinx extensions and I reviewed even more. I really hope that's it :).

There are two functions which do not have a one-liner describing the functions, but a parameter entry. Thus they have this blue line in the table. Could you, @MaxBlesch, quickly add appropriate one-liners?

Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@hmgaudecker
Copy link
Collaborator

Last minute: We are missing things that are disambiguated because the functions change over time. E.g., "vorsorge" does not appear and I had a hard time finding it... Any ideas on how to include these? or should we just make the underlying functions public?

a) Make naming consistent.
b) Remove leading underscores so that they show up in the docs.
@hmgaudecker
Copy link
Collaborator

Alright, I hope this solves it. We should not rename all things to be public. But those that are disambiguated in policies_for_date.load_reforms_for_date().

@tobiasraabe
Copy link
Member Author

@hmgaudecker Merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spelling error in DAG code
3 participants