Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #225 to 0.3.4. #227

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Backport #225 to 0.3.4. #227

merged 3 commits into from
Jul 30, 2020

Conversation

tobiasraabe
Copy link
Member

No description provided.

@tobiasraabe tobiasraabe added this to the v0.3.4 milestone Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (0.3@5df90c5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             0.3     #227   +/-   ##
======================================
  Coverage       ?   94.46%           
======================================
  Files          ?       58           
  Lines          ?     1789           
  Branches       ?        0           
======================================
  Hits           ?     1690           
  Misses         ?       99           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df90c5...aa05a76. Read the comment docs.

hmgaudecker
hmgaudecker approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@tobiasraabe tobiasraabe merged commit 33e1a7f into 0.3 Jul 30, 2020
@tobiasraabe tobiasraabe deleted the backport-225-to-0.3.4 branch July 30, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmgaudecker hmgaudecker hmgaudecker approved these changes

@MaxBlesch MaxBlesch Awaiting requested review from MaxBlesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasraabe @hmgaudecker