New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beginner Tutorials to the GETTSIM Documentation. #232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 60 60
Lines 2101 2101
=======================================
Hits 1920 1920
Misses 181 181 Continue to review full report at Codecov.
|
…icy_functions.ipynb in more detail
These are our drafts for the four tutorials listed in the PR description. The documentation build for this PR can be found here. We have been working on the status of the Some questions that are still open:
We are happy to receive comments and feedback! |
I just meant the basic interface tutorial we added. It ended up being a very similar (just slightly more basic) version of the existing interface tutorial. |
Ok, I see! I understood that there are two duplicates. From my side, it can be merged now. |
Thanks for all your work, looks great! Just a couple of very high-level comments:
|
…wording installation.rst
Thank you very much for the feedback @hmgaudecker ! I think we have addressed all of the comments (feel free to point out if we have missed anything). One last open point concerns the debgugging/troubleshooting tutorial which we hadn't previously worked on. I'm not sure why, but the debug mode, or rather the example we have in the tutorial, does not seem to be throwing the warning or returning only a subset of variables anymore. Maybe someone who has more knowledge of the internals and recent changes than me can weigh in @MaxBlesch @ChristianZimpelmann ? I have pushed my run of the tutorial (I updated some function arguments since they have changed since the tutorial was published) now, so you can compare to the old version here in the main documentation. |
Nvm my last comment, it's working. Thanks @MaxBlesch ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Just out of scope of this one, but I think we should keep it in there anyhow is what to do with the crosswalk. That one should not be placed as prominently anymore, if we want to keep it in there, we want to hide it in some section "compatibility" or so, but I do not have great ideas at present.
https://gettsim--232.org.readthedocs.build/en/232/functions.html# sort of replaces it for the output columns, that we should document a bit better. Maybe have a page with
Data columns
- Basic user inputs
- Typical outputs
- All potential outputs
@MaxBlesch, could you make a suggestion on that one? Feel free to just open a new issue and/or PR if you think that will grow too large (having written this, it already feels like that), I do not have enough bandwidth these days to fully think through it.
Yes. I already work on something like that. But all potential outputs are given by the documentation of functions. Once there are complete docstrings. That's the documentation we want to have?! In any case out of scope of this PR. Very nice work! |
Yes, excellent! In general, we will need think hard on how to package things, so that new users get the important bits at a glance without being overwhelmed by all the information there is in the background.
Indeed, thanks @amageh, @davpahl, @Trichter33! |
What problem do you want to solve?
We (David, Tim, & Annica) will use this PR to work on a set of four tutorials for the documentation that are targeted mainly towards beginner's first contact with GETTSIM. The tutorials build on and expand the existing interface tutorial. The following four tutorials are planned:
params_dict
can be changed to make changes to the policy environment.Feedback is very welcome!
Todo
CHANGES.rst
.