Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinderbonus #283

Merged
merged 11 commits into from Apr 9, 2021
Merged

Kinderbonus #283

merged 11 commits into from Apr 9, 2021

Conversation

ChristianZimpelmann
Copy link
Member

@ChristianZimpelmann ChristianZimpelmann commented Mar 29, 2021

What problem do you want to solve?

Implement Kinderbonus (one-time payment) in 2020 and 2021

Todo

  • Add Kinderbonus parameters
  • Implement kinderbonus_m_basis (potential Kinderbonus)
  • Use Kinderbonus for Günstigerprüfung
  • Adjust test_kindergeld to test for Kinderbonus
  • Adjust test_kindergeld to test for Günstigerprüfung
  • Adjust tutorials

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #283 (6dd659b) into master (f55bc87) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   91.80%   91.85%   +0.05%     
==========================================
  Files          65       65              
  Lines        2440     2455      +15     
==========================================
+ Hits         2240     2255      +15     
  Misses        200      200              
Impacted Files Coverage Δ
gettsim/taxes/eink_st.py 100.00% <ø> (ø)
gettsim/tests/test_favorability_check.py 100.00% <ø> (ø)
gettsim/transfers/benefit_checks/benefit_checks.py 100.00% <ø> (ø)
gettsim/taxes/favorability_check.py 93.75% <100.00%> (+2.44%) ⬆️
gettsim/taxes/kindergeld.py 100.00% <100.00%> (ø)
gettsim/tests/test_benefit_checks.py 100.00% <100.00%> (ø)
gettsim/tests/test_kindergeld.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55bc87...6dd659b. Read the comment docs.

@ChristianZimpelmann ChristianZimpelmann requested review from hmgaudecker and removed request for hmgaudecker March 29, 2021 15:31
@ChristianZimpelmann ChristianZimpelmann linked an issue Mar 29, 2021 that may be closed by this pull request
@hmgaudecker
Copy link
Collaborator

Thanks!!! Before I take a closer look, can you check two things, please?

  • On your to-do list, can the last item be ticked off?
  • Could you have a look at the coverage? Looks to me like the core addition (kinderbonus_m) is not being visited?

@ChristianZimpelmann
Copy link
Member Author

Thanks! Both done now.

Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ChristianZimpelmann ChristianZimpelmann merged commit aac3c3a into master Apr 9, 2021
@ChristianZimpelmann ChristianZimpelmann deleted the kinderbonus branch April 9, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Kinderbonus for 2020
2 participants