Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas 1.4 #337

Merged
merged 2 commits into from Jan 25, 2022
Merged

Pandas 1.4 #337

merged 2 commits into from Jan 25, 2022

Conversation

hmgaudecker
Copy link
Collaborator

What problem do you want to solve?

Pandas 1.4 leads to errors in tests due to stricter indexing rules, adds depreciation warnings for df.append(...). This PR adjusts the code to get rid of them.

Copy link
Member

@ChristianZimpelmann ChristianZimpelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #337 (2f25610) into main (426dc9a) will decrease coverage by 0.03%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   92.84%   92.81%   -0.04%     
==========================================
  Files          67       67              
  Lines        2643     2644       +1     
==========================================
  Hits         2454     2454              
- Misses        189      190       +1     
Impacted Files Coverage Δ
gettsim/taxes/zu_verst_eink/freibetraege.py 100.00% <ø> (ø)
gettsim/synthetic_data/synthetic.py 94.33% <93.75%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426dc9a...2f25610. Read the comment docs.

@hmgaudecker hmgaudecker merged commit edadfca into main Jan 25, 2022
@hmgaudecker hmgaudecker deleted the pandas-1.4 branch January 25, 2022 09:29
hmgaudecker added a commit that referenced this pull request Jan 25, 2022
* Fix indexing error.
* Remove instances of `df.append(...)` because of depreciation warnings.
hmgaudecker added a commit that referenced this pull request Jan 25, 2022
* Fix indexing error.
* Remove instances of `df.append(...)` because of depreciation warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants