Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description vermögen hh #406

Merged
merged 18 commits into from Aug 18, 2022

Conversation

LauraGergeleit
Copy link
Contributor

@LauraGergeleit LauraGergeleit commented Jul 11, 2022

What problem do you want to solve?

Improve the description of wealth in GETTSIM by renaming it from vermögen_hh to vermögen_bedürft_hh, which refers to the assets for means testing of a household.
Including test cases in tests for ALGII, Wohngeld, Kinderzuschlag and Grundsicherung im Alter with positive wealth.
Closes #326.

Todo

  • Change variable name.
  • Adjust description for basic input variable in input_variables.rst.
  • Add testcases for Arbeitslosengeld 2 with positive wealth (see Vermögensfreibetrag #331, precise link).
  • Added testcases for Grundsicherung im Alter with positive wealth.
  • Adding testcases for Kinderzuschlag with wealth above wealth allowance.
  • Adding testcases for Wohngeld with wealth above wealth allowance.
  • Adjusting calculation for Kinderzuschlag, allowing for differences in wealth of child and parents?
  • Add contribution in CHANGES.rst.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #406 (5e36036) into main (7e17d74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   92.42%   92.43%           
=======================================
  Files          76       76           
  Lines        3606     3607    +1     
=======================================
+ Hits         3333     3334    +1     
  Misses        273      273           
Impacted Files Coverage Δ
gettsim/config.py 100.00% <ø> (ø)
gettsim/tests/test_benefit_checks.py 100.00% <ø> (ø)
gettsim/tests/test_grunds_im_alter.py 100.00% <ø> (ø)
gettsim/tests/test_synthetic.py 100.00% <ø> (ø)
gettsim/synthetic_data/synthetic.py 94.91% <100.00%> (ø)
gettsim/tests/test_arbeitsl_geld_2.py 100.00% <100.00%> (ø)
gettsim/tests/test_kinderzuschl.py 100.00% <100.00%> (ø)
gettsim/tests/test_wohngeld.py 95.83% <100.00%> (ø)
...ttsim/transfers/arbeitsl_geld_2/arbeitsl_geld_2.py 100.00% <100.00%> (ø)
...tsim/transfers/benefit_checks/vermoegens_checks.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ChristianZimpelmann ChristianZimpelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! Great work!

@ChristianZimpelmann ChristianZimpelmann merged commit c8ccfa2 into main Aug 18, 2022
@ChristianZimpelmann ChristianZimpelmann deleted the improve_description_vermögen_hh branch August 18, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve description of input variable vermögen_hh
3 participants