Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define supported groupings in config.py #415

Merged
merged 21 commits into from Aug 26, 2022
Merged

Conversation

ChristianZimpelmann
Copy link
Member

@ChristianZimpelmann ChristianZimpelmann commented Aug 26, 2022

What problem do you want to solve?

Defining supported groupings in config.py and referring to them in interface.py instead of using the hardcoded groups there.

  • Define supported groupings in config.py
  • Rename two variables in line with name conventions
  • Refer in several docstrings explicitely to level on which variable is calculated
  • CHANGES.rst

LauraGergeleit and others added 21 commits November 18, 2021 12:12
…able (that should never be necessary). Also rename one more variable.
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #415 (9384b0e) into main (46c2d19) will decrease coverage by 0.00%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   92.46%   92.46%   -0.01%     
==========================================
  Files          76       76              
  Lines        3705     3718      +13     
==========================================
+ Hits         3426     3438      +12     
- Misses        279      280       +1     
Impacted Files Coverage Δ
...ttsim/social_insurance_contributions/arbeitsl_v.py 100.00% <ø> (ø)
...al_insurance_contributions/beitr_bemess_grenzen.py 100.00% <ø> (ø)
gettsim/taxes/eink_st.py 96.15% <ø> (ø)
gettsim/taxes/soli_st.py 100.00% <ø> (ø)
gettsim/taxes/zu_verst_eink/freibetraege.py 84.61% <ø> (ø)
gettsim/taxes/zu_verst_eink/zu_verst_eink.py 100.00% <ø> (ø)
gettsim/transfers/arbeitsl_geld.py 100.00% <ø> (ø)
gettsim/transfers/grunds_im_alter.py 100.00% <ø> (ø)
gettsim/transfers/kinderbonus.py 100.00% <ø> (ø)
gettsim/transfers/kindergeld.py 94.44% <ø> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@LauraGergeleit LauraGergeleit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@ChristianZimpelmann ChristianZimpelmann merged commit 31f6b19 into main Aug 26, 2022
@ChristianZimpelmann ChristianZimpelmann deleted the groupings_config branch August 26, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants