Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindergeldübertrag #744

Closed
wants to merge 19 commits into from
Closed

Kindergeldübertrag #744

wants to merge 19 commits into from

Conversation

MImmesberger
Copy link
Collaborator

@MImmesberger MImmesberger commented May 2, 2024

What problem do you want to solve?

Closes #742

The implementation will still rely on manually removing children from their Bedarfsgemeinschaft (via eigenbedarf_gedeckt) until the corresponding issue #622 has been addressed.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (0bcd40f) to head (f1b0b69).

❗ Current head f1b0b69 differs from pull request most recent head 6389557. Consider uploading reports for the commit 6389557 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   89.46%   89.52%   +0.05%     
==========================================
  Files          51       52       +1     
  Lines        3656     3676      +20     
==========================================
+ Hits         3271     3291      +20     
  Misses        385      385              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristianZimpelmann ChristianZimpelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems overall nicely done. But a couple of comments.

src/_gettsim/transfers/kindergeld.py Outdated Show resolved Hide resolved
src/_gettsim/transfers/kindergeld.py Outdated Show resolved Hide resolved
src/_gettsim/transfers/kindergeld.py Outdated Show resolved Hide resolved
src/_gettsim/transfers/kindergeld.py Outdated Show resolved Hide resolved
@@ -0,0 +1,111 @@
"""Module for the calculation of the Kindergeldübertrag."""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, using the correct Umlaut in the filename results in gibberish and I get a ruff error in the pre-commits (N999)

@MImmesberger
Copy link
Collaborator Author

Should be more careful with squash commits when working on several PRs at the same time, somehow I broke the commit history. Will fix that tomorrow or do a new PR with cherry-picked commits.

@MImmesberger MImmesberger mentioned this pull request May 4, 2024
@MImmesberger
Copy link
Collaborator Author

I have cherry-picked the relevant commits and included them in #751. Closing this one.

MImmesberger added a commit that referenced this pull request May 6, 2024
### What problem do you want to solve?

Closes #742 

The implementation will still rely on manually removing children from
their Bedarfsgemeinschaft (via eigenbedarf_gedeckt) until the
corresponding issue #622 has been addressed.

(This PR is based on #744)
@MImmesberger MImmesberger deleted the kindergeldübertrag branch May 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Kindergeldübertrag
2 participants