-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kindergeldübertrag #744
The head ref may contain hidden characters: "kindergeld\u00FCbertrag"
Kindergeldübertrag #744
Conversation
…ests accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 89.46% 89.52% +0.05%
==========================================
Files 51 52 +1
Lines 3656 3676 +20
==========================================
+ Hits 3271 3291 +20
Misses 385 385 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Seems overall nicely done. But a couple of comments.
@@ -0,0 +1,111 @@ | |||
"""Module for the calculation of the Kindergeldübertrag.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, using the correct Umlaut in the filename results in gibberish and I get a ruff error in the pre-commits (N999)
This reverts commit 7f44059.
Should be more careful with squash commits when working on several PRs at the same time, somehow I broke the commit history. Will fix that tomorrow or do a new PR with cherry-picked commits. |
I have cherry-picked the relevant commits and included them in #751. Closing this one. |
What problem do you want to solve?
Closes #742
The implementation will still rely on manually removing children from their Bedarfsgemeinschaft (via
eigenbedarf_gedeckt
) until the corresponding issue #622 has been addressed.