Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects should be generic, with roles #112

Open
colesmj opened this issue Sep 26, 2020 · 5 comments
Open

Objects should be generic, with roles #112

colesmj opened this issue Sep 26, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@colesmj
Copy link
Collaborator

colesmj commented Sep 26, 2020

Today, we have object types:

  • Element
  • Server
  • Client
  • Process
  • Asset
  • Lambda

It seems that a Server, Client, and Lambda are all specializations of Process or Asset, and really represent the "role" of each; role is really determined by the specific use - a server is the sink for a dataflow, the source is a client. But when describing an object, until the dataflows are determined, why force users to know ahead of time which one they need? Also, a client or server may be a server or a client, based on other data flows...

An alternative suggestion: create a generic "node" (Asset may be the right object already available), and allow assignment of properties that are generic. If roles are needed, assigning a role may add attributes specific to the role(s) added at runtime.
This approach helps with constructing models based on less-than-perfect knowledge of the system.

@colesmj colesmj added the enhancement New feature or request label Sep 26, 2020
@nineinchnick
Copy link
Collaborator

Fully agree! I still have a hard time telling how Process and Server are different...

@nozmore
Copy link
Collaborator

nozmore commented Apr 6, 2021

I still have a hard time telling how Process and Server are different...

Same. I have a collection of microservice applications where the element is both a Server and a Process. I created ServerProcess class in the model py file to get both annotation sets/threat eval.

@colesmj
Copy link
Collaborator Author

colesmj commented Apr 6, 2021 via email

@nozmore
Copy link
Collaborator

nozmore commented Apr 7, 2021

I agree. I have an excel document with sheets for each object type and its annotations. I started going thru all annotations and capturing notes for things I'd like to move, rename, or need clarification on. I have work I would like to do on the threat lib but I want to get a handle on the model first.

@colesmj
Copy link
Collaborator Author

colesmj commented Apr 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants