Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create full Data object from Dataflow.data string #148

Merged
merged 14 commits into from Apr 30, 2021

Conversation

izar
Copy link
Owner

@izar izar commented Mar 30, 2021

The bug report came from a user - strange data objects appeared in the dictionary. This fixes it by creating sane objects instead.

@izar izar requested a review from nineinchnick March 30, 2021 21:12
@ghost
Copy link

ghost commented Mar 30, 2021

Congratulations 🎉. DeepCode analyzed your code in 2.67 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Copy link
Collaborator

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure what problem this addresses. We can continue discussing this on Slack.

pytm/pytm.py Show resolved Hide resolved
pytm/pytm.py Outdated Show resolved Hide resolved
@izar izar added this to the v1.1.3 milestone Apr 12, 2021
README.md Outdated Show resolved Hide resolved
pytm/pytm.py Outdated Show resolved Hide resolved
Izar Tarandach added 6 commits April 13, 2021 17:02
… data is set, distinct from .protocol (for example, JSON over HTTPS). Fixed tests and changed threat rules to account for it - please review threats with 'd.format' in their condition.
@izar izar merged commit 7cabf89 into master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants