render Boundary.inBoundary in the DFD

[redshiftzero]

Here's a simple approach to render nested Boundary objects (fixes #13), let me know what you think

Example:

#!/usr/bin/env python3
from pytm.pytm import Actor, Boundary, TM, Process, Server

tm = TM("example")
tm.description = "my threat model"

datacenter = Boundary("datacenter")
server_rack = Boundary("server rack")
server_rack.inBoundary = datacenter

app_server = Server("application server")
app_server.inBoundary = server_rack

mon_server = Server("monitoring server")
mon_server.inBoundary = server_rack

admin = Actor("admin")
admin.inBoundary = datacenter

tm.process()

before this patch:

after this patch:

[ghost]

DeepCode Report (#29518a)

DeepCode analyzed this pull request.
There are no new issues.

[rgacote]

This looks quite simple. I just started working on a similar boundary w/in boundary approach but I think your approach is simpler. Been looking to have nested boundaries. Will check it out and test.

…

On Tue, Nov 5, 2019 at 10:45 AM redshiftzero ***@***.***> wrote: Here's a simple approach to render nested Boundary objects (fixes #13 <#13>), let me know what you think Example: #!/usr/bin/env python3 from pytm.pytm import Actor, Boundary, TM, Process, Server tm = TM("example") tm.description = "my threat model" datacenter = Boundary("datacenter") server_rack = Boundary("server rack") server_rack.inBoundary = datacenter app_server = Server("application server") app_server.inBoundary = server_rack mon_server = Server("monitoring server") mon_server.inBoundary = server_rack admin = Actor("admin") admin.inBoundary = datacenter tm.process() before this patch: [image: dfd] <https://user-images.githubusercontent.com/7832803/68219021-4b5b1500-ffb3-11e9-93fb-89e4dd42d944.png> after this patch: [image: dfd] <https://user-images.githubusercontent.com/7832803/68218964-2ff00a00-ffb3-11e9-9026-4fbba9b983a4.png> ------------------------------ You can view, comment on, or merge this pull request online at: #52 Commit Summary - render Boundary.inBoundary in the DFD (#13) File Changes - *M* pytm/pytm.py <https://github.com/izar/pytm/pull/52/files#diff-0> (6) Patch Links: - https://github.com/izar/pytm/pull/52.patch - https://github.com/izar/pytm/pull/52.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#52>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMPVVFMVAUS6B7FBZHOK3TQSGIJZANCNFSM4JJD5JBQ> .

-- Raymond Cote, President voice: +1.603.924.6079 email: rgacote@AppropriateSolutions.com skype: ray.cote Schedule a meeting: https://calendly.com/ray_cote/60min/

[izar]

Looks great, simple and elegant, thank you!

[redshiftzero]

thanks for the fast review!