Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure all items has correct color (based on scope) #93

Merged
merged 1 commit into from
Jun 15, 2020
Merged

ensure all items has correct color (based on scope) #93

merged 1 commit into from
Jun 15, 2020

Conversation

nineinchnick
Copy link
Collaborator

Ensure all items has correct color (based on scope). Currently actors not in scope are drawn as black, which is confusing considering other items out of scope are gray.

@nineinchnick nineinchnick requested a review from izar as a code owner March 26, 2020 17:19
@ghost
Copy link

ghost commented Mar 26, 2020 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 0.307 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@nineinchnick nineinchnick mentioned this pull request Mar 26, 2020
Merged
izar
izar approved these changes Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@izar izar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason fontcolor didn't work for me way back then. Hopefully this is a good change on graphviz's part.

@izar izar merged commit 5b41c93 into OWASP:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izar izar izar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nineinchnick @izar