Add concept of global resources which can be shared across applications #80
Conversation
There was a problem hiding this comment.
Thanks, @lceleban-dd, this is an awesome update 👍 A few minor comments and let's ship it.
|
|
||
| lazy val globalResources: Seq[AkkeeperResource] = { | ||
| if (akkeeperConfig.hasPath("globalResources")) { | ||
| akkeeperConfig.getConfigList("globalResources").asScala.map(akkeeperResourceFromConfig) |
There was a problem hiding this comment.
Can we please name this global-resources to be consistent with other property names.
| private[config] def akkeeperResourceFromConfig(config: Config): AkkeeperResource = { | ||
| AkkeeperResource( | ||
| new URI(config.getString("uri")), | ||
| config.getString("localPath"), |
| val dst = copyResourceToStagingDir(dstFs, srcStream, dstPath) | ||
| val dstStatus = dstFs.getFileStatus(dst) | ||
| create(dstFs, dstStatus) | ||
| val dst = copyResourceToStagingDir(srcStream, dstPath) |
There was a problem hiding this comment.
[Thought|Optional] Perhaps it makes sense to rename all createLocalResource methods to uploadLocalResource to draw a clear line between the case when we copy the resource and when we use the original source instead.
| @@ -19,6 +19,7 @@ private[akkeeper] object LocalResourceNames { | |||
| val AkkeeperJarName = "akkeeper.jar" | |||
| val UserJarName = "user.jar" | |||
| val UserConfigName = "user_config.conf" | |||
| val LauncherConfigName = "launcher_config.conf" | |||
There was a problem hiding this comment.
I wouldn't say it's a launcher config per se. More like application or akkeeper config.
There was a problem hiding this comment.
Renamed to application.conf
| @@ -19,6 +19,7 @@ private[akkeeper] object LocalResourceNames { | |||
| val AkkeeperJarName = "akkeeper.jar" | |||
| val UserJarName = "user.jar" | |||
| val UserConfigName = "user_config.conf" | |||
| val LauncherConfigName = "application.conf" | |||
There was a problem hiding this comment.
Shall we rename the constant as well?
No description provided.