Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Current values #93

Closed
gullitmiranda opened this issue Jun 6, 2020 · 4 comments
Closed

Feature Request: Current values #93

gullitmiranda opened this issue Jun 6, 2020 · 4 comments

Comments

@gullitmiranda
Copy link

what do you think about adding the possibility to register the pre-change in the versions?

with this feature we:

  1. Direct show changes instead of load all previous versions at find last change. Which is even more critical with multiple fields.
  2. can search specific changes like: task status updated from TODO to DONE

i believe this feature can be added without changing the current lib behavior

@izelnakri
Copy link
Owner

izelnakri commented Jun 14, 2020

Hi @gullitmiranda, the initial inspiration of this project the ruby paper_trail gem had item_from field, however this results in too much data being replicated. It is always possible to write custom queries and optimise them so on purpose I leave out the item_from field from this library. Let me know if this didn't answer your question, thanks for your request.

@gullitmiranda
Copy link
Author

I agree if the item_from replicates the current value completely. But I don't see much of a problem in recording just the changed values.

In addition, this feature could be disabled by default, as is strict mode.

@izelnakri
Copy link
Owner

@gullitmiranda ok after some consideration, if you are willing to create a PR for this optional behavior, I think we can merge it after good tests for the cases of this feature when toggled and not.

@izelnakri
Copy link
Owner

Hi @gullitmiranda , I"m closing this issue since its been more than 4 years. Feel free to create a new issue or PR if you're still missing this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants