Adding index #2
Merged
Adding index #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can add this as an actual comment :D 👍 # Uncomment if you want to add the following indexes to speed up special queries:
# create index(:versions, [:event, :item_id, :item_type]) |
|
@izelnakri I can't get the purpose of this commenting out. Why do we need it? |
|
having indexes on those fields is a great idea however some people might not need them or need them differently, having that index has a small speed con if its not needed. By putting a comment warning we can explicitly state that that part of the functionality is optional. Normally I like self-documenting/no-comments code however for this case I think it suits better if we have comments. |
|
@izelnakri done |
desoulter
pushed a commit
to desoulter/paper_trail
that referenced
this pull request
Feb 16, 2018
…hanges merged izelnakri#2 Split deep_serialize function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.