fixed for non-regular primary key #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense, thank you! One question before I merge this, why do you think my uuid tests didnt catch this? I guess our test coverage doesn't cover this bug? Could you look into this as well? I think we should release this fix along with its relevant test case. |
izelnakri
reviewed
Feb 16, 2018
lib/paper_trail.ex
Outdated
| @@ -322,7 +322,7 @@ defmodule PaperTrail do | |||
| %Version{ | |||
| event: "update", | |||
| item_type: changeset.data.__struct__ |> Module.split() |> List.last(), | |||
| item_id: changeset.data.id, | |||
| item_id: get_model_id_from_changeset(changeset), | |||
There was a problem hiding this comment.
This could simply be get_model_id(changeset.data) instead of a new function I think
|
Yeah, the function is unnecessary, removed. I'm working for a legacy database that there are some non-regular named fields, hoping to be useful to others :) |
|
This is very nice thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #33