Ecto 3.0-rc.1 support #51
Conversation
|
awesome, thanks for your work! I'll review this soon. |
| end | ||
|
|
||
| @optional_fields ~w(name is_active website city address facebook twitter founded_in) | ||
| @optional_fields ~w(name is_active website city address facebook twitter founded_in)a |
There was a problem hiding this comment.
Ecto 3.0 Ecto.Changeset.cast/3 with list of strings is deprecated, you have to pass list of atoms
https://github.com/elixir-ecto/ecto/blob/master/CHANGELOG.md#deprecations
example/.iex.exs
Outdated
| @@ -1 +0,0 @@ | |||
| import Ecto.Query | |||
There was a problem hiding this comment.
this is to import Ecto.Query functions globally(to Kernel) I dont think its redundant, so I would like to keep it.
There was a problem hiding this comment.
I forgot to put it back, sorry.
| {:ecto_sql, "~> 3.0-rc", override: true}, | ||
| {:postgrex, ">= 0.0.0-rc"}, | ||
| {:jason, "~> 1.0"}, | ||
| {:paper_trail, path: "../"} |
| {:ex_doc, ">= 0.0.0", only: :dev}, | ||
| {:postgrex, "~> 0.13.0"} | ||
| {:postgrex, ">= 0.0.0-rc"}, |
There was a problem hiding this comment.
I think I just copied it and pasted from mix.exs of generated phoenix 1.4.0-rc app. Do you want me to change it to the latest version or "=> 0.0.0"?
|
Great work overall, could you also update the README/documentation regarding the changes? Thank you! |
|
merged your PR, thank you! Currently cannot release due |
Mainly changed Ecto.Date to Date and replaced Poison with Jason per http://blog.plataformatec.com.br/2018/10/a-sneak-peek-at-ecto-3-0-breaking-changes/.
Also fixed some deprecation warnings for
Multi.run