Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with mariadb #71

Merged
merged 2 commits into from Feb 27, 2020
Merged

Make it compatible with mariadb #71

merged 2 commits into from Feb 27, 2020

Conversation

ggpasqualino
Copy link
Contributor

I am really sorry, the last release will break if the client doesn't have postgrex there because it's listed as one of the applications to be started, my bad :/

I have plugged this into an example with myxql to test it now and realized that it can't handle the origin to be read after writing, so I also made it optional.

@izelnakri
Copy link
Owner

Thanks for your consideration and fix. I will need integration tests to merge these changes. Also I want to point out I was intending to support only postgres. However depending on the tests I'm willing to merge the changes. I will also need to set up the CI correctly it seems.

@izelnakri
Copy link
Owner

Reading this again, it seems tests are not needed to merge these changes but I would like to have some integration tests on mariadb/on CI if we are going to officially support MariaDB now.

@izelnakri izelnakri merged commit 5855d10 into izelnakri:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants