Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geocoding private header fix #383

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Geocoding private header fix #383

merged 3 commits into from
Jan 12, 2023

Conversation

egoldfarb
Copy link
Contributor

@egoldfarb egoldfarb commented Jan 11, 2023 •
edited
Loading

Fixes #350

@egoldfarb
Revert "Fix NBGeocoderMetadataHelper.h import to make all schemes com…
6ba88d2 
…pilable"

This reverts commit c10c2f8.
@egoldfarb
Revert "Fix 'umbrella header for module does not include...' error"
335d142 
This reverts commit 4377b21.
@egoldfarb
A better fix attempt for iziz#313 by making NBGeocoderMetadataHelper …
c33c5d3 
…a private header. Reverts commits 4377b21 and c10c2f8. Update podspec with sqlite dependency. Move geocoding test bundle to test target/directory.
@paween paween merged commit 9d408d2 into iziz:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FONickReichard FONickReichard FONickReichard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libPhoneNumberGeocoding doesn't compile
3 participants
@egoldfarb @FONickReichard @paween